Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LIVE-12571 #6863

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix LIVE-12571 #6863

merged 1 commit into from
May 16, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented May 15, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix an issue where the password is not recognized anymore because of a reset of accounts attribute.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS requested a review from cksanders May 15, 2024 15:16
@KVNLS KVNLS self-assigned this May 15, 2024
@KVNLS KVNLS requested a review from a team as a code owner May 15, 2024 15:16
@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 15, 2024
cksanders
cksanders requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@cksanders cksanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog

@mcayuelas-ledger
Copy link
Contributor

This need to target release no?

@KVNLS KVNLS force-pushed the fix/LIVE-12571 branch from 2856c61 to 39f0d43 Compare May 15, 2024 15:26
@KVNLS
Copy link
Member Author

KVNLS commented May 15, 2024

This need to target release no?

@cksanders will handle the fix for the release

@KVNLS KVNLS requested a review from cksanders May 15, 2024 15:26
@KVNLS KVNLS force-pushed the fix/LIVE-12571 branch from 39f0d43 to cf435fd Compare May 15, 2024 15:55
@KVNLS KVNLS merged commit 7869330 into develop May 16, 2024
34 checks passed
@KVNLS KVNLS deleted the fix/LIVE-12571 branch May 16, 2024 08:23
@gre gre mentioned this pull request May 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@cksanders cksanders cksanders approved these changes

Assignees

@KVNLS KVNLS

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KVNLS @mcayuelas-ledger @cksanders